This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
fix two bugs in signed address handling #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we'd only set the TTL if the addresses were new.
Previously, two calls to ConsumePeerRecord could interleave and cause us to keep _old_ addresses with a _new_ record.
Stebalien
changed the title
vyzo
approved these changes
Jun 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConsumePeerRecordto accept peer records with sequence numbers equal to existing peer records. This lets us update the TTL. Otherwise, we'll never update the TTL for a peer's addresses until they create a new record.