This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
Record which direction the resource was blocked #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
approved these changes
Jul 8, 2022
| @@ -320,11 +320,13 @@ func (r StatsTraceReporter) ConsumeEvent(evt rcmgr.TraceEvt) { | |||
| tags := []tag.Mutator{tag.Upsert(scopeTag, scopeName), tag.Upsert(resourceTag, resource)} | |||
There was a problem hiding this comment.
Does it make sense to allocate a slice of length 3 here, so the append later doesn't cause any allocs?
There was a problem hiding this comment.
I'm actually not appending to this slice. I make another slice of tags in case the event has both delta in/out (I don't think we are doing this anywhere but we can't assume we will never do this).
There was a problem hiding this comment.
I allocated the other slices upfront so maybe they'll be on the stack and not cause a heap alloc. Based on this SO answer/related tweet it seems like the Go 1.17 runtime (and above?) will do stack allocations here.
I couldn't find any official documentation around this though.
marten-seemann
approved these changes
Jul 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds another tag to record if the blocked thing was an inbound or outbound thing