This repository has been archived by the owner on Dec 7, 2019. It is now read-only.
make closing the query events channel safe #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Stebalien
force-pushed
the
fix/go-ipfs-5616
branch
from
f04fb2d
to
d46dc62
Compare
1. Instead of accepting a passed-in channel, create one (and return a read-only channel). 2. Close the channel when the context is canceled. Together, these allow us to safely close the event channel. Technically, this is an API-breaking change but this is (a) an internal API and (b) unavoidable (I think). That is, I'm pretty sure there's no way to fix this without changing this method signature somehow (we need to somehow synchronize closing of this channel with writing to it). fixes ipfs/kubo#5616
Stebalien
force-pushed
the
fix/go-ipfs-5616
branch
from
d46dc62
to
92c8ec8
Compare
Stebalien
commented
Oct 19, 2018
|
|
||
| peer "github.com/libp2p/go-libp2p-peer" | ||
| pstore "github.com/libp2p/go-libp2p-peerstore" | ||
| ) | ||
|
|
||
| const RoutingQueryKey = "RoutingQueryEvent" |
magik6k
approved these changes
Oct 22, 2018
Stebalien
force-pushed
the
fix/go-ipfs-5616
branch
from
6bbeaa0
to
c401079
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes ipfs/kubo#5616
Basically, we need to be able to close and write to the channel under the same lock. With this change, we can manage the channel with the context itself.