This repository has been archived by the owner on Sep 10, 2022. It is now read-only.
use the Resource Manager #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyzo
reviewed
Dec 22, 2021
marten-seemann
force-pushed
the
rcmgr
branch
from
a59b688
to
e068fbb
Compare
vyzo
reviewed
Dec 30, 2021
| } | ||
| return nil, fmt.Errorf("gater rejected connection with peer %s and addr %s with direction %d", | ||
| sconn.RemotePeer().Pretty(), maconn.RemoteMultiaddr(), dir) | ||
| } | ||
| if p == "" && connScope != nil { | ||
| if err := connScope.SetPeer(sconn.RemotePeer()); err != nil { |
There was a problem hiding this comment.
we need a Done in the error path, as we own it here.
There was a problem hiding this comment.
so where is this getting Done? The caller is responsible?
There was a problem hiding this comment.
69 tasks
vyzo
reviewed
Jan 2, 2022
marten-seemann
force-pushed
the
rcmgr
branch
5 times, most recently
from
722a883
to
be66941
Compare
marten-seemann
force-pushed
the
rcmgr
branch
3 times, most recently
from
92eaefd
to
a01b952
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on libp2p/go-libp2p-core#229.
TODO: write tests.