fix flaky TestFastDisconnect identify test #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
commented
Sep 24, 2021
| @@ -36,10 +37,11 @@ func TestFastDisconnect(t *testing.T) { | |||
|
|
|||
| // Kill the connection, and make sure we're completely disconnected. | |||
| s.Conn().Close() | |||
There was a problem hiding this comment.
The problem here was that sometimes, we'd end up with two connections (for example, one TCP and one QUIC connection). Of course, calling s.Conn().Close() here would only close one of them, which is why the loop on the next line would never terminate.
There was a problem hiding this comment.
Alternative fix would be to loop over all connections and close them.
There was a problem hiding this comment.
actually, let's do that -- it's the right thing to do.
vyzo
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1157.