fix structured logging in holepunch coordination #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
fix-holepunch-structured-logging
branch
from
e33a8fb
to
0112646
Compare
marten-seemann
force-pushed
the
fix-holepunch-structured-logging
branch
2 times, most recently
from
1cd8d67
to
be2d703
Compare
marten-seemann
force-pushed
the
fix-holepunch-structured-logging
branch
from
be2d703
to
b0a9660
Compare
Stebalien
requested changes
Oct 4, 2021
| @@ -174,7 +174,7 @@ func (hs *Service) beginDirectConnect(p peer.ID) error { | |||
| // It first attempts a direct dial (if we have a public address of that peer), and then | |||
| // coordinates a hole punch over the given relay connection. | |||
| func (hs *Service) DirectConnect(p peer.ID) error { | |||
| log.Debugw("got inbound proxy conn from peer", p) | |||
| log.Debugw("got inbound proxy conn", "peer", p.Pretty()) | |||
There was a problem hiding this comment.
No need to call Pretty(), the peer ID will get encoded on-demand if debug logging is enabled.
marten-seemann
force-pushed
the
fix-holepunch-structured-logging
branch
from
b0a9660
to
8f2212a
Compare
Stebalien
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.