Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make the Type field required in the HolePunch protobuf #1241

Merged
merged 1 commit into from
Nov 21, 2021
Merged

make the Type field required in the HolePunch protobuf #1241

merged 1 commit into from
Nov 21, 2021

Conversation

marten-seemann
Copy link
Contributor

vyzo
vyzo approved these changes Nov 21, 2021
View reviewed changes
Copy link
Contributor

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldnt we regen the pb?

vyzo
vyzo approved these changes Nov 21, 2021
View reviewed changes
Copy link
Contributor

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah omitted in display, nm

@marten-seemann marten-seemann merged commit cac4cf3 into master Nov 21, 2021
@marten-seemann marten-seemann deleted the holepunch-protobuf-required-type branch November 30, 2021 14:18
@aschmahmann aschmahmann mentioned this pull request Dec 1, 2021
Closed
80 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

@vyzo vyzo vyzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marten-seemann @vyzo @mxinden