Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move go-libp2p-transport-upgrader here #1463

Merged
merged 85 commits into from
Apr 27, 2022
Merged

move go-libp2p-transport-upgrader here #1463

merged 85 commits into from
Apr 27, 2022

Commits on Jan 19, 2018

  1. initial commit

    @Stebalien
    Stebalien committed Jan 19, 2018
    Configuration menu
    Copy the full SHA
    ede46e0 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2018

  1. fix nil dereference

    @Stebalien
    Stebalien committed Jan 20, 2018
    Configuration menu
    Copy the full SHA
    4822176 View commit details
    Browse the repository at this point in the history

  2. nicer stringers

    @Stebalien
    Stebalien committed Jan 20, 2018
    Configuration menu
    Copy the full SHA
    cf38072 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2018

  1. keep accepting and negotiating connections until we have 16 ready and… 

    … queued up

Otherwise, we'll have an annoying saw-tooth pattern where we'll accept a bunch
of connections, set them up in parallel, and then wait until we pass them all
back up to the swarm before accepting any more.

This commit allows us to queue up 16 ready connections before ceasing to accept
any new connections. We'll still probably have a saw-tooth pattern under heavy
load but it should be less pronounced (and we can improve the situation by
upping the queue size.
    @Stebalien
    Stebalien committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    61cd627 View commit details
    Browse the repository at this point in the history

  2. fix comment on why we don't need to wait on the context 

    Also, add a context canceled check to the loop just in case (accept could, if
buggy, return temporary errors after it's closed).
    @Stebalien
    Stebalien committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    a950fa7 View commit details
    Browse the repository at this point in the history

  3. remove unused count function from threshold

    @Stebalien
    Stebalien committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    cec0d9f View commit details
    Browse the repository at this point in the history

  4. Merge pull request #2 from libp2p/feat/accept-queue 

    keep accepting and negotiating connections until we have 16 ready and queued up
    @Stebalien
    Stebalien committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    6b92f28 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2018

  1. fix off-by-one error in the threshold

    @marten-seemann
    marten-seemann committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    be4a5f4 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2018

  1. add tests for the listener

    @marten-seemann
    marten-seemann committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    90789da View commit details
    Browse the repository at this point in the history

  2. wait after accepting a new connection if the queue is full

    @marten-seemann
    marten-seemann committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    516978c View commit details
    Browse the repository at this point in the history

  3. Merge pull request #6 from marten-seemann/better-threshold-usage 

    wait after accepting a new connection if the queue is full
    @Stebalien
    Stebalien committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    15e5327 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2018

  1. Merge pull request #3 from marten-seemann/fix-threshold-off-by-one-error 

    fix off-by-one error in the threshold
    @Stebalien
    Stebalien committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    0212611 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2018

  1. complete rename

    @Stebalien
    Stebalien committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    1317fb9 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #5 from marten-seemann/listener-tests 

    add tests for the listener
    @Stebalien
    Stebalien committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    a08397a View commit details
    Browse the repository at this point in the history

  3. fix tests for rename

    @Stebalien
    Stebalien committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    dc4b4ae View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2018

  1. fix for interface move

    @Stebalien
    Stebalien committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    0db3c0a View commit details
    Browse the repository at this point in the history

  2. fix for moved insecure security transport

    @Stebalien
    Stebalien committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    6055448 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2018

  1. check if connection is closed before returning it from Accept 

    It could have been sitting around for a while.
    @Stebalien
    Stebalien committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    6fbbb67 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2018

  1. ensure we force use of the libp2p protector if ForcePrivateNetwork is… 

    … set
    @Stebalien
    Stebalien committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    07e87ba View commit details
    Browse the repository at this point in the history

  2. better document handleIncoming

    @Stebalien
    Stebalien committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    32b0643 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2018

  1. remove dependency on the tcp transport 

    fixes #7
    @Stebalien
    Stebalien committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    dbf3f83 View commit details
    Browse the repository at this point in the history

  2. use mplex for tests instead of yamux

    @Stebalien
    Stebalien committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    66b1a47 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2019

  1. annotate errors

    @Stebalien
    Stebalien committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    8ceb856 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2019

  1. Merge pull request #11 from libp2p/fix/better-negotiation-errors 

    annotate errors
    @Stebalien
    Stebalien committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    5fc9b71 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2019

  1. improve correctness of closing connections on failure 

    may be related to ipfs/kubo#6197

(but I can't find one)
    @Stebalien
    Stebalien committed Apr 26, 2019
    Configuration menu
    Copy the full SHA
    e87a4e3 View commit details
    Browse the repository at this point in the history

  2. test: cleanup after tests 

    Otherwise, setting global variables races with running goroutines.
    @Stebalien
    Stebalien committed Apr 26, 2019
    Configuration menu
    Copy the full SHA
    f418d2c View commit details
    Browse the repository at this point in the history

  3. Merge pull request #19 from libp2p/fix/close-on-err 

    improve correctness of closing connections on failure
    @Stebalien
    Stebalien committed Apr 26, 2019
    Configuration menu
    Copy the full SHA
    dc54d8a View commit details
    Browse the repository at this point in the history

Commits on May 22, 2019

  1. dep: import go-libp2p-mplex into the libp2p org

    @Stebalien
    Stebalien committed May 22, 2019
    Configuration menu
    Copy the full SHA
    67b7b27 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #21 from libp2p/dep/import-smux 

    dep: import go-libp2p-mplex into the libp2p org
    @Stebalien
    Stebalien committed May 22, 2019
    Configuration menu
    Copy the full SHA
    9667b21 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2019

  1. Consolidate abstractions and core types into go-libp2p-core (#28)

    @Stebalien
    Stebalien committed May 24, 2019
    Configuration menu
    Copy the full SHA
    57d79cc View commit details
    Browse the repository at this point in the history

  2. Merge pull request #22 from libp2p/feat/consolidate-abstractions 

    Consolidate abstractions and core types into go-libp2p-core (#28)
    @Stebalien
    Stebalien committed May 24, 2019
    Configuration menu
    Copy the full SHA
    b1dd953 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2019

  1. complete the migration to consolidated types. (#23)

    @raulk
    raulk committed May 26, 2019
    Configuration menu
    Copy the full SHA
    9bcb09e View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2019

  1. fix an incorrect error message 

    "security stream multiplexer" is the worst sort of confusing.
    @Stebalien
    Stebalien committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    f081071 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #27 from libp2p/fix/error-message 

    fix an incorrect error message
    @Stebalien
    Stebalien committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    aabc5e4 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2020

  1. use the ipnet.PSK instead of the ipnet.Protector for private networks

    @marten-seemann @Stebalien
    marten-seemann authored and Stebalien committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    1c35066 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #45 from libp2p/generalize-private-network 

    use the ipnet.PSK instead of the ipnet.Protector for private networks
    @Stebalien
    Stebalien committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    2267728 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2020

  1. simplify tests by removing ginkgo/gomega. (#60)

    @raulk
    raulk committed May 13, 2020
    Configuration menu
    Copy the full SHA
    b19703d View commit details
    Browse the repository at this point in the history

  2. remove leftover ginkgo test file. (#61)

    @raulk
    raulk committed May 13, 2020
    Configuration menu
    Copy the full SHA
    59da2c1 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2020

  1. call the connection gater when accepting connections and after crypto… 

    … handshake (#55)
    @aarshkshah1992
    aarshkshah1992 committed May 15, 2020
    Configuration menu
    Copy the full SHA
    bf33d1e View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2020

  1. fix int to string conversion in tests, update Go version on CI

    @marten-seemann
    marten-seemann committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    d365120 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #69 from libp2p/fix-int-to-string-conversion 

    fix int to string conversion in tests, update Go version on CI
    @Stebalien
    Stebalien committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    44b29c4 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2020

  1. pass contexts to OpenStream in tests

    @marten-seemann
    marten-seemann committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    508be7e View commit details
    Browse the repository at this point in the history

  2. Merge pull request #70 from libp2p/open-stream-context 

    pass contexts to OpenStream in tests
    @marten-seemann
    marten-seemann committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    ebab543 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2021

  1. Implement support for simultaneous open (#25) 

    * implement support for simultaneous open

Co-authored-by: aarshkshah1992 <[email protected]>
    @vyzo @aarshkshah1992
    vyzo and aarshkshah1992 committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    4453d7a View commit details
    Browse the repository at this point in the history

  2. thread underlying conn Stat to allow transports to propagate stat inf… 

    …ormation
    @vyzo
    vyzo committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    2397d98 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #71 from libp2p/feat/conn-stat 

    Expose underlying transport connection stat where available
    @vyzo
    vyzo committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    cffe493 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2021

  1. stop using the deprecated go-multiaddr-net

    @marten-seemann
    marten-seemann committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    b743906 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #72 from libp2p/dont-use-go-multiaddr-net 

    stop using the deprecated go-multiaddr-net
    @marten-seemann
    marten-seemann committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    3a37a04 View commit details
    Browse the repository at this point in the history

  3. don't listen on all interfaces in tests

    @marten-seemann
    marten-seemann committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    76f4936 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2021

  1. Merge pull request #73 from libp2p/dont-listen-on-all-interfaces 

    don't listen on all interfaces in tests
    @Stebalien
    Stebalien committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    bda39a2 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2021

  1. fix staticcheck

    @marten-seemann
    marten-seemann committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    8739d56 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #74 from libp2p/fix-staticcheck 

    fix staticcheck
    @Stebalien
    Stebalien committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    8acc055 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2021

  1. fix typo in error message

    @marten-seemann
    marten-seemann committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    3ac4a61 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2021

  1. Merge pull request #77 from libp2p/fix-typo 

    fix typo in error message
    @marten-seemann
    marten-seemann committed Jul 24, 2021
    Configuration menu
    Copy the full SHA
    efd8047 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2021

  1. chore: update deps

    @marten-seemann
    marten-seemann committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    fc8779c View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2021

  1. Merge pull request #78 from libp2p/update-deps 

    chore: update deps
    @marten-seemann
    marten-seemann committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    8d16690 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2021

  1. add the peer ID to SecureInbound

    @marten-seemann
    marten-seemann committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    e267d49 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #83 from libp2p/check-peer-id-on-inbound 

    add the peer ID to SecureInbound
    @marten-seemann
    marten-seemann committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    e2284ac View commit details
    Browse the repository at this point in the history

  3. increase timeout in TestConnectionsClosedIfNotAccepted on CI

    @marten-seemann
    marten-seemann committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    289fcae View commit details
    Browse the repository at this point in the history

  4. Merge pull request #85 from libp2p/fix-flaky-accept-test 

    increase timeout in TestConnectionsClosedIfNotAccepted on CI
    @marten-seemann
    marten-seemann committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    403b19e View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2021

  1. chore: update go-log

    @marten-seemann
    marten-seemann committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    893c9a4 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2021

  1. Merge pull request #88 from libp2p/update-go-log 

    chore: update go-log
    @marten-seemann
    marten-seemann committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    e53323d View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2021

  1. use the new network.ConnStats

    @marten-seemann
    marten-seemann committed Dec 12, 2021
    Configuration menu
    Copy the full SHA
    85de7f0 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #92 from libp2p/conn-stats 

    use the new network.ConnStats
    @marten-seemann
    marten-seemann committed Dec 12, 2021
    Configuration menu
    Copy the full SHA
    aa4826e View commit details
    Browse the repository at this point in the history

  3. fix flaky TestAcceptQueueBacklogged test

    @marten-seemann
    marten-seemann committed Dec 12, 2021
    Configuration menu
    Copy the full SHA
    fe89a27 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #96 from libp2p/fix-flaky-accept-queue-backlogged 

    fix flaky TestAcceptQueueBacklogged test
    @marten-seemann
    marten-seemann committed Dec 12, 2021
    Configuration menu
    Copy the full SHA
    e9a4b83 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2021

  1. reset the temporary error catcher delay after successful accept

    @marten-seemann
    marten-seemann committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    f06d0df View commit details
    Browse the repository at this point in the history

  2. make the accept timeout configurable, stop using transport.AcceptTimeout

    @marten-seemann
    marten-seemann committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    b16a446 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2021

  1. Merge pull request #98 from libp2p/configurable-accept-timeout 

    make the accept timeout configurable, stop using transport.AcceptTimeout
    @marten-seemann
    marten-seemann committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    20281dd View commit details
    Browse the repository at this point in the history

  2. Merge pull request #97 from libp2p/reset-temp-err-catcher 

    reset the temporary error catcher delay after successful accept
    @marten-seemann
    marten-seemann committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    c622cb0 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2022

  1. use the new transport.Upgrader interface

    @marten-seemann
    marten-seemann committed Jan 2, 2022
    Configuration menu
    Copy the full SHA
    a3f424b View commit details
    Browse the repository at this point in the history

  2. rename the constructor from NewUpgrader to New

    @marten-seemann
    marten-seemann committed Jan 2, 2022
    Configuration menu
    Copy the full SHA
    5a79888 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2022

  1. remove UpgradeInbound and UpgradeOutbound

    @marten-seemann
    marten-seemann committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    e8056e8 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #100 from libp2p/upgrader-interface 

    use the new transport.Upgrader interface
    @marten-seemann
    marten-seemann committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    17c6e5e View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2022

  1. rename the package to upgrader

    @marten-seemann
    marten-seemann committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    8f6a3dc View commit details
    Browse the repository at this point in the history

  2. Merge pull request #101 from libp2p/rename-package 

    rename the package to upgrader
    @marten-seemann
    marten-seemann committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    873efba View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2022

  1. use the Resource Manager

    @marten-seemann
    marten-seemann committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    ccf4315 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2022

  1. Merge pull request #99 from libp2p/rcmgr 

    use the Resource Manager
    @marten-seemann
    marten-seemann committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    8d193b3 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2022

  1. always set the peer if the peer scope is null 

    Removes the very ugly contract of "if you know the peer you have set it" and makes the
code robust against upstream bugz.
    @vyzo
    vyzo committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    67fe765 View commit details
    Browse the repository at this point in the history

  2. fix tests

    @vyzo
    vyzo committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    191278d View commit details
    Browse the repository at this point in the history

  3. more robust nil check

    @vyzo
    vyzo committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    f75dfe1 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2022

  1. avoid reflection

    @vyzo
    vyzo committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    8350e75 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #104 from libp2p/fix/nil-peer-scope 

    Fix nil peer scope issues
    @vyzo
    vyzo committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    b6118ea View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2022

  1. move go-libp2p-transport-upgrader here

    @marten-seemann
    marten-seemann committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    981c9cf View commit details
    Browse the repository at this point in the history

  2. switch from github.com/libp2p/go-libp2p-transport-upgrader to p2p/net… 

    …/upgrader
    @marten-seemann
    marten-seemann committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    9dc18ed View commit details
    Browse the repository at this point in the history