rcmgr: use autoscaling limits #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoPolo
approved these changes
Jul 2, 2022
| setProtocolLimits(limiter, holepunch.Protocol, | ||
| limiter.DefaultProtocolLimits.WithMemoryLimit(1, 4<<20, 64<<20), | ||
| peerLimit(2, 2, 2)) | ||
| addServiceAndProtocolLimit(config, |
There was a problem hiding this comment.
I know this was what the old code did, but why do we need to set both the service and protocol limit? Shouldn’t the service limit cover the protocol? And/or shouldn’t the protocol limit cover the service?
There was a problem hiding this comment.
Yes, for services that use a single protocol. Identify uses multiple protocol IDs, so at least in theory, it could make sense to set separate limits.
|
Don’t forget to update the resource manager and this PR’s go.mod before merge |
marten-seemann
force-pushed
the
rcmgr-auto-scaling
branch
from
59d643a
to
c8044d2
Compare
marten-seemann
force-pushed
the
rcmgr-auto-scaling
branch
from
c8044d2
to
f346c5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on libp2p/go-libp2p-resource-manager#48.