noise: use Noise Extension to negotiate the muxer during the handshake

[julian88110]

Muxer negotiation using early data of Noise handshake.
This is the Noise implementation of issue #1789

[marten-seemann]

@julian88110 Could you rebase (git rebase) this PR on top of the current master? Looks like there are still commits from your earlier TLS change in the commit history here.

[marten-seemann]

This is looking really good. Just a few nits!

[marten-seemann]

Code LGTM.

Something seems to be wrong with the Protobuf though. This PR adds a single entry to the Noise extension. This shouldn't lead to a 537 LOC change in the generated .pb.go file.

[julian88110]

This might be related to proto buf compiler version difference, I used the latest protbuf 21.8 and protoc-gen-gogo/1.3.2_2/ to compile the protobuf file, I do notice it changed a lot of the generated file content, even the imported modules are different, indicating a significant code generation change.

[marten-seemann]

This might be related to proto buf compiler version difference, I used the latest protbuf 21.8 and protoc-gen-gogo/1.3.2_2/ to compile the protobuf file, I do notice it changed a lot of the generated file content, even the imported modules are different, indicating a significant code generation change.

I'm not opposed to switching to a different protobuf compiler, but we should be intentional about it, and consistent across the code base. We should also use (Unified) CI to check that all of our .pb.go files are up to date.

I've recompiled the Protobuf here, so this PR can make progress.

[julian88110]

This might be related to proto buf compiler version difference, I used the latest protbuf 21.8 and protoc-gen-gogo/1.3.2_2/ to compile the protobuf file, I do notice it changed a lot of the generated file content, even the imported modules are different, indicating a significant code generation change.

I'm not opposed to switching to a different protobuf compiler, but we should be intentional about it, and consistent across the code base. We should also use (Unified) CI to check that all of our .pb.go files are up to date.

I've recompiled the Protobuf here, so this PR can make progress.

Thanks Marten.
Agreed, that was why I asked for the protobuf compiler versions some time ago. Instead of tracking it off record, We should have something like a tool chain config file or dev-env setup config to specify our tool chains and their versions.