Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.23.4 #1864

Merged
merged 4 commits into from
Nov 9, 2022
Merged

Release v0.23.4 #1864

merged 4 commits into from
Nov 9, 2022

Conversation

MarcoPolo
Copy link
Collaborator

@MarcoPolo MarcoPolo commented Nov 8, 2022

@p-shahi
Copy link
Member

p-shahi commented Nov 8, 2022

👍 / 👎 on including #1835

@marten-seemann
Copy link
Contributor

👍 / 👎 on including #1835

#1835 is a new feature, so this shouldn't go into a patch release.

@marten-seemann
Copy link
Contributor

image

The commit history doesn't look right. This branch should be based on top of `release-v023`, not `release-v0233` (sorry for the confusing naming!).

@MarcoPolo MarcoPolo marked this pull request as ready for review November 9, 2022 01:09
@MarcoPolo
Copy link
Collaborator Author

Will merge after CI passes and cut a new release

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

Suggested version: v0.23.4
Comparing to: v0.23.3 (diff)

Changes in go.mod file(s):

(empty)

gorelease says:

# diagnostics
go.mod: the following requirements are needed
	github.com/libp2p/go-yamux/[email protected]
Run go mod tidy to add missing requirements.
required module github.com/microcosm-cc/[email protected] retracted by module author: Retract older versions as only latest is to be depended upon

# summary
Suggested version: v0.23.4

gocompat says:

(empty)

Cutting a Release (when not on master)

This PR is targeting release-v023, which is not the default branch.
If you wish to cut a release once this PR is merged, please add the release label to this PR.

@MarcoPolo MarcoPolo merged commit 9ade760 into release-v023 Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants