Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/protocol: remove deprecated Negotiator.NegotiateLazy #1869

Merged
merged 1 commit into from
Nov 11, 2022
Merged

core/protocol: remove deprecated Negotiator.NegotiateLazy #1869

merged 1 commit into from
Nov 11, 2022

Conversation

marten-seemann
Copy link
Contributor

This function was deprecated more than half a year ago.

@marten-seemann marten-seemann mentioned this pull request Nov 9, 2022
Merged
@p-shahi p-shahi mentioned this pull request Nov 9, 2022
Closed
34 tasks
MarcoPolo
MarcoPolo approved these changes Nov 11, 2022
View reviewed changes
Copy link
Collaborator

@MarcoPolo MarcoPolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to remove it from the multistream package.

@marten-seemann
Copy link
Contributor Author

We still need to remove it from the multistream package.

@MarcoPolo multiformats/go-multistream#92

@marten-seemann marten-seemann merged commit 8a43c6b into master Nov 11, 2022
@marten-seemann marten-seemann deleted the remove-deprecated-negotiator-negotiate-lazy branch November 11, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoPolo MarcoPolo MarcoPolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
go-libp2p
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marten-seemann @MarcoPolo