move NAT mapping logic out of the host, add tests for NAT handling #2248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
simplify-nat
branch
3 times, most recently
from
f071c82
to
c6c5099
Compare
MarcoPolo
reviewed
Apr 12, 2023
| continue | ||
| } | ||
|
|
||
| var ( |
There was a problem hiding this comment.
🙏 . Thanks for getting rid of this
marten-seemann
force-pushed
the
simplify-nat
branch
3 times, most recently
from
cf2e70d
to
043162e
Compare
marten-seemann
force-pushed
the
simplify-nat
branch
from
043162e
to
60e9ade
Compare
MarcoPolo
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for #2229.
There's a few packages involved in NAT handling here:
p2p/net/nat: Usesgo-natperiodically renew NAT mappings and query for IP address changes.p2p/host/basic/natmgr.go: Listens forListen/ListenClosenotifications from the swarm and tries to obtain NAT mappings for our listen addresses. Provides aGetMapping(ma.Multiaddr) ma.Multiaddrmethod that applies NAT mappings to existing multiaddresses.