-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
websocket: add reuseport support #2261
Open
chaitanyaprem
wants to merge
19
commits into
libp2p:master
Choose a base branch
from
chaitanyaprem:feat/websocket-reuseport
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
e7b4454
feat: added REUSEPORT support for websocket listeners #1435
chaitanyaprem 445f860
Added support for using reuseport in connection Dialing #1435
chaitanyaprem 4279f92
chore: cleaned-up the websocket reuse test
chaitanyaprem 80b3b34
chore: addressed review comments for #2261
chaitanyaprem 804ba36
chore: address linter error in websocket test script
chaitanyaprem f73c1ba
Merge branch 'master' into feat/websocket-reuseport
chaitanyaprem cc83e5a
chore: addressed review comments wrt test.
chaitanyaprem 9c539a6
Merge branch 'libp2p:master' into feat/websocket-reuseport
chaitanyaprem 153829a
chore: addressed review comments and cleanedup test script
chaitanyaprem 07aae9b
Update websocket_test.go
chaitanyaprem ad59795
feat: use reuseport wihle dialing client connections if set
chaitanyaprem b170b43
Merge branch 'master' into feat/websocket-reuseport
chaitanyaprem 863f51d
Merge branch 'master' into feat/websocket-reuseport
chaitanyaprem 4cccef8
Merge branch 'libp2p:master' into feat/websocket-reuseport
chaitanyaprem 4179d80
Merge branch 'libp2p:master' into feat/websocket-reuseport
chaitanyaprem 8840f19
chore:comment lb check in reuseport test to avoid flaky results
chaitanyaprem f660226
chore: fix gofmt error
chaitanyaprem 3fea95c
Merge branch 'master' into feat/websocket-reuseport
chaitanyaprem c01a725
chore: increase number of clients to avoid flakiness of reuseport test
chaitanyaprem File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to use the transport's
reuseTransport
field. Otherwise this will never reuse the port we're listening on when dialing. I guess you can pass them in tonewListener
.Also add a test that we are reusing port when dialing.