webtransport: initialize the certmanager when creating the transport #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves a deadlock when AddCertHashes is called before Listen. It also means that we're initializing a certmanaer even if we're only using the WebTransport transport for dialing and not for listening, but that's a fringe use case anyway.
3 tasks
MarcoPolo
approved these changes
May 4, 2023
MarcoPolo
pushed a commit
that referenced
this pull request
May 4, 2023
…2268) This solves a deadlock when AddCertHashes is called before Listen. It also means that we're initializing a certmanaer even if we're only using the WebTransport transport for dialing and not for listening, but that's a fringe use case anyway.
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves a deadlock when
AddCertHashesis called beforeListen. It also means that we're initializing a certmanaer even if we're only using the WebTransport transport for dialing and not for listening, but that's a fringe use case anyway.