swarm: change maps with multiaddress keys to use strings #2284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
force-pushed
the
fix-addr-map
branch
2 times, most recently
from
5d04613
to
417b8cc
Compare
marten-seemann
approved these changes
May 11, 2023
|
The new test case seems flaky: |
|
@marten-seemann |
marten-seemann
approved these changes
May 12, 2023
MarcoPolo
pushed a commit
that referenced
this pull request
May 30, 2023
* swarm: change maps with multiaddress keys to use strings * fix test * fix more flakiness
marten-seemann
pushed a commit
that referenced
this pull request
May 30, 2023
* swarm: change maps with multiaddress keys to use strings * fix test * fix more flakiness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2283
string(addr.Bytes())is already used in peerstore. #2283Fixes one more instance in
routed.gohttps://github.com/libp2p/go-libp2p/blob/master/p2p/host/routed/routed.go#L122