identify: filter received addresses based on the node's remote address #2300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
identify-filter-addrs
branch
from
f9b68a3
to
d960964
Compare
|
If you want a connection with a remote addr on private IP and a remote addr on loopback ip, it should be possible to do this by listening on "0.0.0.0" address and dialing only the private or the loopback address. Testing public ips does look impossible. |
sukunrt
reviewed
May 19, 2023
p2p/protocol/identify/id.go
Outdated
Comment on lines
770
to
769
| if _, err := cab.ConsumePeerRecord(signedPeerRecord, ttl); err != nil { | ||
| log.Debugf("error adding signed addrs to peerstore: %v", err) |
There was a problem hiding this comment.
for this to be effective, these addresses need to be filtered too, right?
There was a problem hiding this comment.
Right. I've done some digging and convinced myself that the ConsumePeerRecord API is flawed. Will open a separate issue for that.
marten-seemann
force-pushed
the
identify-filter-addrs
branch
from
d960964
to
cf0ca1b
Compare
sukunrt
approved these changes
Jun 1, 2023
|
Yes. We can take signed peer records separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, this is impossible to test. I tried using mocknet, but of course that thing is so horribly broken that it can't even reliably set the correct remote address of a connection. It fails at the most easy thing it was designed to do.