autonatv2: implement autonatv2 spec #2469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
force-pushed
the
sukun/autonat-v2-2
branch
from
5477354
to
fe5e13e
Compare
sukunrt
force-pushed
the
sukun/autonat-v2-2
branch
from
fe5e13e
to
7d524a9
Compare
Yes, that part will go in the address pipeline. |
sukunrt
force-pushed
the
sukun/autonat-v2-2
branch
2 times, most recently
from
e09ef04
to
c55e2af
Compare
3 tasks
sukunrt
force-pushed
the
sukun/autonat-v2-2
branch
from
5bddfb0
to
acb1c88
Compare
sukunrt
force-pushed
the
sukun/autonat-v2-2
branch
5 times, most recently
from
6149b00
to
83babed
Compare
4 tasks
sukunrt
force-pushed
the
sukun/autonat-v2-2
branch
from
83babed
to
e080d99
Compare
sukunrt
force-pushed
the
sukun/autonat-v2-2
branch
from
e080d99
to
af0ac51
Compare
sukunrt
force-pushed
the
sukun/autonat-v2-2
branch
5 times, most recently
from
3ff9598
to
a3138cf
Compare
MarcoPolo
reviewed
May 30, 2024
MarcoPolo
reviewed
May 30, 2024
sukunrt
force-pushed
the
sukun/autonat-v2-2
branch
2 times, most recently
from
f212a0f
to
0aa1911
Compare
sukunrt
commented
Jun 5, 2024
|
Can we default to having autonatv2 disabled initially? I want folks to opt-in to it at the start until we gain some more confidence with experience. |
MarcoPolo
reviewed
Jun 7, 2024
sukunrt
force-pushed
the
sukun/autonat-v2-2
branch
from
1219f9e
to
cf8807b
Compare
MarcoPolo
approved these changes
Jun 10, 2024
MarcoPolo
reviewed
Jun 19, 2024
p2p/protocol/autonatv2/client.go
Outdated
| lenBuf = lenBuf[:n] | ||
|
|
||
| for remain := numBytes; remain > 0; { | ||
| _, err = w.Write(lenBuf) |
There was a problem hiding this comment.
won't this overshoot the amount of data to dial? The old version did ddResp.Data = ddResp.Data[:end].
fwiw, I think extra allocs on the client side matter less than on the server side. I would be okay if the code path on the client side was straightforward at the expense of a couple extra allocs (what we had before was fine.)
There was a problem hiding this comment.
I agree with the suggestion to remove this on the client. We can always add this side later on when we start using this from rest of the code.
won't this overshoot the amount of data to dial?
I think this is okay. Servers should handle this case. It's only 4kB more.
There was a problem hiding this comment.
We should update the spec if the client may send a bit more data.
MarcoPolo
approved these changes
Jun 19, 2024
MarcoPolo
approved these changes
Jun 20, 2024
sukunrt
force-pushed
the
sukun/autonat-v2-2
branch
from
898d51c
to
9667cd8
Compare
5 tasks
mergify bot
pushed a commit
to libp2p/rust-libp2p
that referenced
this pull request
Aug 8, 2024
Closes: #4524 This is the implementation of the evolved AutoNAT protocol, named AutonatV2 as defined in the [spec](https://github.com/libp2p/specs/blob/03718ef0f2dea4a756a85ba716ee33f97e4a6d6c/autonat/autonat-v2.md). The stabilization PR for the spec can be found under libp2p/specs#538. The work on the Rust implementation can be found in the PR to my fork: umgefahren#1. The implementation has been smoke-tested with the Go implementation (PR: libp2p/go-libp2p#2469). The new protocol addresses shortcomings of the original AutoNAT protocol: - Since the server now always dials back over a newly allocated port, this made #4568 necessary; the client can be sure of the reachability state for other peers, even if the connection to the server was made through a hole punch. - The server can now test addresses different from the observed address (i.e., the connection to the server was made through a `p2p-circuit`). To mitigate against DDoS attacks, the client has to send more data to the server than the dial-back costs. Pull-Request: #5526.
TimTinkers
pushed a commit
to unattended-backpack/rust-libp2p
that referenced
this pull request
Sep 14, 2024
Closes: libp2p#4524 This is the implementation of the evolved AutoNAT protocol, named AutonatV2 as defined in the [spec](https://github.com/libp2p/specs/blob/03718ef0f2dea4a756a85ba716ee33f97e4a6d6c/autonat/autonat-v2.md). The stabilization PR for the spec can be found under libp2p/specs#538. The work on the Rust implementation can be found in the PR to my fork: umgefahren#1. The implementation has been smoke-tested with the Go implementation (PR: libp2p/go-libp2p#2469). The new protocol addresses shortcomings of the original AutoNAT protocol: - Since the server now always dials back over a newly allocated port, this made libp2p#4568 necessary; the client can be sure of the reachability state for other peers, even if the connection to the server was made through a hole punch. - The server can now test addresses different from the observed address (i.e., the connection to the server was made through a `p2p-circuit`). To mitigate against DDoS attacks, the client has to send more data to the server than the dial-back costs. Pull-Request: libp2p#5526.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #2422
Will add metrics for this in a separate PR.