config: warn if connmgr limits conflict with rcmgr

[piersy]

closes: #1707

If the high water mark of the connection manager exceeds the total connection limit of the resource manager then a warning will be issued at node startup.

@MarcoPolo, I actually think it would be neater to pass an int to CheckLimit as opposed to what I've currently implemented.

CheckLimit(systemLimit connmgr.GetterConnLimit)

Let me know what you think

[MarcoPolo]

I actually think it would be neater to pass an int to CheckLimit as opposed to what I've currently implemented.

That could make sense. Who would own the interface that the resourcemanager implements to get the int?

I think I prefer this model because the interface is owned by the conn manager, and the resource manager is implementing it so that it can be used to check against.

I almost would consider flipping these so that the resource manager is the one checking against other things, since it's the one that is the ultimate source of truth. But I don't think it really matters.

Besides a single comment to hopefully give a nicer warning, I think this is good. Thank you!

[piersy]

Hi @MarcoPolo could you elaborate on how to improve the warning message?

Currently the warnings would take the following format:

conn manager high water limit: 8, exceeds the system limit of: 4

[piersy]

Hi @sukunrt, thanks for the review, I think I've addressed all your points.

[sukunrt]

Thank you, @piersy