-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swarm: fix recursive resolving of DNS multiaddrs #2564
Conversation
feb3779
to
3695e19
Compare
The code works, but I should add a test case before we merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks fine to me. But should https://github.com/libp2p/go-libp2p/blob/master/p2p/transport/websocket/websocket.go#L139 ignore dnsaddr
addresses since the actual host will be obtained after resolving the dnsaddr
Just smoked-tested it with
(see the |
3695e19
to
a7c46cb
Compare
I added a test case, and linked the original issue. |
cce6b5b
to
052bcde
Compare
No description provided.