tcp: fix build on riscv64 #2590
Conversation
There was a problem hiding this comment.
Can you add comments linking to marten-seemann/tcp#1 there is no reason this can't work on riscv, just we need theses constants defined.
| @@ -1,4 +1,4 @@ | |||
| //go:build !windows | |||
| //go:build !windows && !riscv64 | |||
There was a problem hiding this comment.
| //go:build !windows && !riscv64 | |
| // riscv64 see: https://github.com/marten-seemann/tcp/pull/1 | |
| //go:build !windows && !riscv64 |
There was a problem hiding this comment.
Are you sure this works? Doesn't the go:build need to come first?
There was a problem hiding this comment.
I don't think so, go:build line has to come before package:
> cat a.go
// test
//go:build doNotBuild
package aaa
const "test" + 42
> cat b.go
package aaa
func A() {}
> go build .
> echo $status
0
| @@ -1,4 +1,4 @@ | |||
| //go:build !linux && !darwin && !windows | |||
| //go:build !linux && !darwin && !windows && !riscv64 | |||
There was a problem hiding this comment.
| //go:build !linux && !darwin && !windows && !riscv64 | |
| // riscv64 see: https://github.com/marten-seemann/tcp/pull/1 | |
| //go:build !linux && !darwin && !windows && !riscv64 |
|
Could this be included in |
@Jorropo Can you elaborate on the sudden urgency please? The Kubo issue has been open for years. |
|
I'm now running Kubo on some riscv64 hardware and I'm lazy, so I would rather not have to repatch it every time but that is subjective. Imo the best time to fix this would have been fixed in december 2021 or january 2022 shortly after marten-seemann/tcp#1 was sent but it didn't happend for reasons unknown to me and I don't have a time machine to do anything about it, so the next best time to do it is now. I can wait for v0.32.0 if that is your question. |
|
This doesn't seem like a kind of patch that justifies cutting a patch release. This will be included in v0.32. |
|
I miss-understood there would be a v0.31.1 for the resource manager desync issue. |
Co-authored-by: Jorropo <[email protected]>
|
I added one of the comments for the build flags. I don't think we need to repeat in 3 files. |
* tcp: fix build on riscv64 * explain why riscv64 doesn't work Co-authored-by: Jorropo <[email protected]> --------- Co-authored-by: Jorropo <[email protected]>
No description provided.