swarm: add loopback to low timeout filter #2595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
requested changes
Oct 6, 2023
There was a problem hiding this comment.
I've changed my mind here considering this:
There are a few more ranges from http://www.iana.org/assignments/iana-ipv4-special-registry/iana-ipv4-special-registry.xhtml that aren't in that list. I'm not sure if there's a reason or if it was just forgotten. I'm happy to extend this PR to add the missing ones as well.
Let's remove this lowTimeoutFilters construct and use manet.IsPublicAddr or manet.IsPrivateAddr. That will keep this definition in one place.
https://pkg.go.dev/github.com/multiformats/go-multiaddr/net#IsPrivateAddr
dennis-tra
force-pushed
the
low-timeout-loopback
branch
from
464e330
to
e3d6cbc
Compare
|
Changed to use |
dennis-tra
added a commit
to probe-lab/zikade
that referenced
this pull request
Oct 6, 2023
Context: - libp2p/go-libp2p#2595 - #48
marten-seemann
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sukunrt suggested lowering
swarm.WithDialTimeoutLocalto prevent our tests from timing out because of blocking dials. In our tests, we connect via loopback addresses, and I noticed that theswarm.WithDialTimeoutLocalwasn't applied.In this PR, I added the loopback CIDR to the list of CIDRs to which the local timeout applies.
There are a few more ranges from http://www.iana.org/assignments/iana-ipv4-special-registry/iana-ipv4-special-registry.xhtml that aren't in that list. I'm not sure if there's a reason or if it was just forgotten. I'm happy to extend this PR to add the missing ones as well.
These are missing: