circuitv2: don't check ASN for private addrs #2611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
approved these changes
Oct 19, 2023
| @@ -74,7 +74,7 @@ func (c *constraints) AddReservation(p peer.ID, a ma.Multiaddr) error { | |||
|
|
|||
| var asnReservations []time.Time | |||
| var asn string | |||
| if ip.To4() == nil { | |||
| if ip.To4() == nil && manet.IsPublicAddr(a) { | |||
There was a problem hiding this comment.
A comment would be helpful, explaining why we skip this for private addresses.
sukunrt
force-pushed
the
sukun/autorelay-flake
branch
from
60241db
to
5d7bc70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is responsible for some of the flakiness of the autorelay testsuite. Loading the ASN table takes a lot of time. I think we can optimise the underlying library but this change is harmless since localhost / private addresses wouldn't be associated with an ASN.