Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webrtc: fix race in TestRemoveConnByUfrag #2620

Merged
merged 1 commit into from
Oct 26, 2023
Merged

webrtc: fix race in TestRemoveConnByUfrag #2620

merged 1 commit into from
Oct 26, 2023

Conversation

sukunrt
Copy link
Member

@sukunrt sukunrt commented Oct 26, 2023 •
edited
Loading

  1. Checking pointer equality here is fine.
  2. require.Equal(x, y) does a field by field comparison of x and y's fields. This causes a race condition when comparing fields accessed by other goroutines.

@marten-seemann marten-seemann merged commit 2c36d31 into master Oct 26, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marten-seemann marten-seemann marten-seemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sukunrt @marten-seemann