Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swarm: remove /ip6zone component from listen addresses #2662

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marten-seemann
Copy link
Contributor

@marten-seemann marten-seemann commented Dec 6, 2023

Part of #2659.

/ip6zone addresses shouldn't be advertised. This PR adds logic to remove the ip6zone component from addresses returned by Swarm.ListenAddresses and Swarm.InterfaceListenAddresses.

@jclab-joseph Does this solve your problem?

@jclab-joseph
Copy link

jclab-joseph commented Dec 6, 2023

No this is the exact opposite of my intention.
My PR(#2660) was to enable Listen for ip6zone correctly to enable p2p communication with link-local address.
However, this PR excludes ip6zone.

The reason I excluded in Addrs rather than ListenAddresses in my PR was to enable Listen but not Announce (to networks outside of Link-local).

@marten-seemann marten-seemann marked this pull request as ready for review December 7, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants