Add reuseport functionality to websocket protocol (v2) #2719
Conversation
Update tests Invert default state - reuseport is disabled Add a test for port reuse on dial
| "github.com/libp2p/go-reuseport" | ||
| ) | ||
|
|
||
| func reuseportIsAvailable() bool { |
There was a problem hiding this comment.
Right now this is just overhead - I added it for parity with the TCP implementation that includes checking of a LIBP2P_TCP_REUSEPORT environment variable to change the setting.
| func EnableReuseport() Option { | ||
| return func(t *WebsocketTransport) error { | ||
| t.enableReuseport = true | ||
| return nil | ||
| } | ||
| } |
There was a problem hiding this comment.
This is the opposite option from the TCP implementation - there we have it enabled by default, here it needs to be explicitly enabled. I figured it might be better to go the more conservative route.
| conn, err := listener.Accept() | ||
| if err != nil { | ||
| // Stop condition - this happens when the listener is closed. | ||
| require.ErrorIs(t, err, transport.ErrListenerClosed) | ||
| return | ||
| } |
There was a problem hiding this comment.
It's possible to just start listeners above and defer Close() calls to it. Then when the test function completes and execution "falls off the end" the listener.Close() call will unblock this and Accept() call will fail with an error.
Still, I think I prefer that one can see what will happen during the test just by reading it. To me it's better than "something will happen after the test is done too". This is a bit ugly but explicit. I'm open to any criticism :)
This PR adds the reuseport functionality for websocket protocol.
The
TestReusePortOnDialtests this implementation by starting to listen on a random port, then dialing another endpoint and verifying that the dial used the same port we were previously listening on.TestReusePortOnListenstarts two listeners and twenty dialers and (on Linux) verifies that requests were distributed among both listeners; on Windows and MacOS we can't make such guarantees, so we just verify that everything worked, and all requests were indeed handled.This PR offers an alternative implementation and operates in the same space as #2261.
Kudos to @chaitanyaprem for his work, I have implemented his documentation references and was inspired by his test for multiple listeners and connection distribution.
The tests for websocket implementation are somewhat noisy (on master too), I don't think warnings like those below stem from these changes: