quic: make server cmd use RFC 9000 instead of draft-29 #2751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I didn't even know we had this. We should have an Example test for this. I'll add one soon unless you beat me to it. |
|
Closing this in favor of #2753 so that I can push the change. You will still have the original commit associated with you @leonrinkel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for QUIC draft-29 has been dropped in v0.30.0, however the transport server cmd has still been using draft-29 and thus fails with error
unknown QUIC versionsince that release.This PR makes
p2p/transport/quic/cmd/server/main.gouse RFC 9000, i.e./quic-v1instead of/quic, so that the standalone client/server test commands work again.