Adhere to request.Context when roundtripping on a stream #2796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows HTTP request timeout and cancellation to work. Fixes #2533
gammazero
force-pushed
the
gammazero/adhere-request-context
branch
from
f5dc013
to
1ec7ce7
Compare
|
Thanks @gammazero! I've made a small change to attempt to signal to the lower level that it should cancel the read by setting a read deadline. What do you think? |
|
Yes, to read deadline. The read should be canceled. |
MarcoPolo
reviewed
May 16, 2024
MarcoPolo
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows HTTP request timeout and cancellation to work.
Fixes #2533