feat: core/transport: Add SkipResolver interface #2989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
approved these changes
Oct 1, 2024
Comment on lines
47
to
49
| // Transport interface | ||
| var _ transport.Transport = (*Client)(nil) | ||
| var _ transport.SkipResolver = (*Client)(nil) |
There was a problem hiding this comment.
Also similar documentation here, so that in case some one does actually embed this, they remember to wrap the SkipResolver interface too.
MarcoPolo
force-pushed
the
marco/impl-resolver-circuit-tpt
branch
from
c4880bc
to
bccdb6a
Compare
sukunrt
reviewed
Oct 10, 2024
sukunrt
approved these changes
Oct 10, 2024
MarcoPolo
force-pushed
the
marco/impl-resolver-circuit-tpt
branch
from
76ba58f
to
ff92001
Compare
MarcoPolo
added a commit
that referenced
this pull request
Oct 16, 2024
* Remove unused resolver in basic host * Refactor Swarm.resolveAddrs Refactors how DNS Address resolution works. * lint * Move MultiaddrDNSResolver interface to core * Reserve output space for addresses left to resolve * feat: core/transport: Add SkipResolver interface (#2989) * Rebase on top of resolveAddrs refactor * Add comments * Sanitize address inputs when returning a reservation message (#3006)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the implied SNI is dropped when connecting over a p2p-circuit address. For example if you connected to a peer over
/dns/example.com/wss/p2p/qmFoo/p2p-circuit/p2p/qmTargetthe swarm would resolve example.com without preserving the SNI information needed forWSS. The WebSocket transport would only get the IP address of example.com without knowning the host name it needed to use for the SNI.We had the same problem previously when dialing a wss address. See #1597. This was fixed by letting transports resolve the multiaddr instead of the swarm. This case is similar, except that we want to tell the swarm to just skip resolving altogether since the inner transport will resolve the multiaddr later.