Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make the {F=>f}iltersConnectionGater private. #946

Merged
merged 1 commit into from
May 20, 2020
Merged

make the {F=>f}iltersConnectionGater private. #946

merged 1 commit into from
May 20, 2020

Conversation

raulk
Copy link
Member

@raulk raulk commented May 20, 2020

There's no reason for this adapter to be public and muddy the public namespace:

  • The user can only set Filters via the constructor.
  • In no other place would a user need to convert an existing Filters to a ConnectionGater. ConnectionGaters are also set via the constructor.

@raulk raulk mentioned this pull request May 20, 2020
Merged
@aarshkshah1992 aarshkshah1992 self-requested a review May 20, 2020 12:22
@raulk raulk merged commit d4d6adf into master May 20, 2020
@raulk raulk deleted the fix/filters-gater-private branch May 20, 2020 15:27
@Stebalien Stebalien mentioned this pull request May 26, 2020
Closed
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarshkshah1992 aarshkshah1992 aarshkshah1992 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raulk @aarshkshah1992