implement CloseRead/CloseWrite #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
force-pushed
the
feat/rw-close
branch
from
7527c51
to
85b53b3
Compare
Stebalien
force-pushed
the
feat/rw-close
branch
from
85b53b3
to
7f5a301
Compare
vyzo
reviewed
Aug 28, 2020
Stebalien
force-pushed
the
feat/rw-close
branch
from
7f5a301
to
f8ae6b8
Compare
willscott
reviewed
Aug 28, 2020
bench_test.go
Outdated
| @@ -1,3 +1,4 @@ | |||
| //+build !race | |||
There was a problem hiding this comment.
Hm. I actually meant to apply this to mplex, not here... (one of the benchmarks there fails if it's too slow).
Comment on lines
+23
to
+24
| halfOpen halfStreamState = iota | ||
| halfClosed |
There was a problem hiding this comment.
comment on the direction of which half?
There was a problem hiding this comment.
Either half. There's one state for each half.
| } | ||
| } | ||
|
|
||
| func TestHalfClose(t *testing.T) { |
There was a problem hiding this comment.
would be good to also have a code path to test the HalfReset closing path
There was a problem hiding this comment.
Do you mean CloseRead?
There was a problem hiding this comment.
(there's no half reset)
Stebalien
force-pushed
the
feat/rw-close
branch
from
053f153
to
6ed2b1f
Compare
|
Test issue caused by #33. |
Stebalien
force-pushed
the
feat/rw-close
branch
from
6ed2b1f
to
fa4a0b4
Compare
vyzo
approved these changes
Aug 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, fix handling of reset after close. If the remote side sends an EOF and then an RST, we now only apply that to the write side of the stream.
Part of libp2p/go-libp2p-core#166.
NOTE: I've split the read/write logic here so, even if we decide to go with something else, it shouldn't be that much more work on top of this patch.