This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
fix!: only discover bootstrap peers once and tag them on discovery #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bootstrap peers should be used in an intial DHT self query to find peers that are KAD-close to us. We do not need to rediscover the same peers over and over again, instead we should just discover them once, use them to query for peers near our PeerId then we can disconnect from them like any other peer Browsers peers may wish to never let the tag expire so they stay connected to the preload nodes. 1. Instead of "discovering" the same peers every few seconds, only discover them once 2. Tag the peers in the peer store with an expiring value to prevent any potential connection being culled before we've used the bootstrap nodes to query for peers close to us BREAKING CHANGE: the `interval` option has been renamed `timeout` and peers are now only discovered once
mpetrunic
approved these changes
Sep 22, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Sep 23, 2022
## [3.0.0](v2.0.1...v3.0.0) (2022-09-23) ### ⚠ BREAKING CHANGES * the `interval` option has been renamed `timeout` and peers are now only discovered once ### Bug Fixes * only discover bootstrap peers once and tag them on discovery ([#142](#142)) ([cd41d94](cd41d94))
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bootstrap peers should be used in an intial DHT self query to find peers that are KAD-close to us.
We do not need to rediscover the same peers over and over again, instead we should just discover them once, use them to query for peers near our PeerId then we can disconnect from them like any other peer
BREAKING CHANGE: the
intervaloption has been renamedtimeoutand peers are now only discovered once