Skip to content
This repository has been archived by the owner on Nov 25, 2022. It is now read-only.

deps!: upgrade interface-transport to ^2.0.0 #18

Closed
wants to merge 1 commit into from
Closed

deps!: upgrade interface-transport to ^2.0.0 #18

wants to merge 1 commit into from

Conversation

ckousik
Copy link
Contributor

@ckousik ckousik commented Oct 6, 2022

Upgrader can now accept UpgraderOptions for outgoing streams.

@ckousik
feat: upgrade interface-transport to ^2.0.0
0e360a0 
Upgrader can now accept UpgraderOptions for outgoing streams.
MarcoPolo
MarcoPolo approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@MarcoPolo MarcoPolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I'm not sure if this is a breaking change or not. Since the "transport" component type def has changed

@achingbrain achingbrain changed the title feat: upgrade interface-transport to ^2.0.0 deps: upgrade interface-transport to ^2.0.0 Oct 6, 2022
@MarcoPolo MarcoPolo changed the title deps: upgrade interface-transport to ^2.0.0 deps!: upgrade interface-transport to ^2.0.0 Oct 6, 2022
MarcoPolo
MarcoPolo suggested changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@MarcoPolo MarcoPolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to edit the commit message to include a ! before merging. I tried making this change, but couldn't push changes to the repo.

I think I could probably include it in the squashed commit, but not totally sure so not going to do that now.

@MarcoPolo MarcoPolo mentioned this pull request Oct 6, 2022
Merged
@MarcoPolo MarcoPolo closed this Oct 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MarcoPolo MarcoPolo MarcoPolo requested changes

@achingbrain achingbrain Awaiting requested review from achingbrain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ckousik @MarcoPolo