This repository has been archived by the owner on Apr 8, 2020. It is now read-only.
Adds key-composer to support import and export to pem #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satazor
reviewed
Apr 19, 2019
src/index.js
Outdated
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| const bs58 = require('bs58') | |||
| const multihashing = require('multihashing-async') | |||
| const keyComposer = require('crypto-key-composer') | |||
There was a problem hiding this comment.
Perhaps it would be better to do const { composePrivateKey, decomposePrivateKey }. The benefit is that it will be easier to perform tree-shaking by bundlers, as we are importing only what we need at the require level.
There was a problem hiding this comment.
Sure! I'll do that when fixing the linting errors which I'm not sure what the maintainers prefer
|
Hey, there's a linting error due to too many callbacks in the tests. Should I structure tests differently to avoid this? That would mean that the tests would be less clean |
|
You can do a block disable for now in the tests because we will change to async await shortly |
|
@satazor @hugomrdias done! |
AlbertoElias
force-pushed
the
master
branch
3 times, most recently
from
09b2219
to
ec178c7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on bringing https://github.com/ipfs-shipyard/js-crypto-key-composer into libp2p-crypto to support
importandexportin non-RSA keys like ed25519 and secp256k1.This is the latter, and necessary for the work happening here: https://github.com/AlbertoElias/js-libp2p-crypto/tree/use-key-composer
This is part of the work done for this issue: libp2p/js-libp2p-crypto#145
cc @satazor @dignifiedquire @hugomrdias