Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

navigator.userAgent is unreliable in determining if the browser is webkit on linux #318

Closed
MarcoPolo opened this issue May 2, 2023 · 1 comment · Fixed by #319
Closed

navigator.userAgent is unreliable in determining if the browser is webkit on linux #318

MarcoPolo opened this issue May 2, 2023 · 1 comment · Fixed by #319

Comments

@MarcoPolo
Copy link
Contributor

MarcoPolo commented May 2, 2023 •
edited
Loading

Seeing failure in CI and locally on a linux box that should have been fixed by #313. The problem is that the user agent reported is "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.4 Safari/605.1.15", which doesn't let us know if this is linux or mac.

Seeing this issue on adding webkit to js-libp2p libp2p/js-libp2p#1627 on this run.

Not sure why the CI here isn't hitting it. Maybe the browser was updated? I'll run the CI again to check.
@MarcoPolo
Copy link
Contributor Author

The browser was probably updated. See new failure in this repo: https://github.com/libp2p/js-libp2p-crypto/actions/runs/4608311179/jobs/8670470410#step:5:1057

@MarcoPolo MarcoPolo mentioned this issue May 2, 2023
Merged
achingbrain pushed a commit that referenced this issue May 5, 2023
@MarcoPolo
fix: Remove unreliable webkit-linux useragent check (#319)
8f8df5c 
Closes #318
github-actions bot pushed a commit that referenced this issue May 5, 2023
@semantic-release-bot
chore(release): 1.0.16 [skip ci]
b8fa2d3 
## [1.0.16](v1.0.15...v1.0.16) (2023-05-05)

### Bug Fixes

* Remove unreliable webkit-linux useragent check ([#319](#319)) ([8f8df5c](8f8df5c)), closes [#318](#318)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Remove unreliable webkit-linux useragent check libp2p/js-libp2p-crypto
1 participant
@MarcoPolo