Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

fix: put optional args last for key export #154

Merged
merged 1 commit into from
Jul 10, 2019
Merged

fix: put optional args last for key export #154

merged 1 commit into from
Jul 10, 2019

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Jul 10, 2019 •
edited
Loading

Fixes #153

Note: This probably isn't going to require any upstream code changes, because there is only one allowed export format and it's the default

vasco-santos
vasco-santos approved these changes Jul 10, 2019
View reviewed changes
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jacobheun
jacobheun approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I'll note this as a breaking change in the squash.

@jacobheun jacobheun merged commit d675670 into master Jul 10, 2019
@jacobheun jacobheun deleted the fix/optional-arg-order branch July 10, 2019 17:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vasco-santos vasco-santos vasco-santos approved these changes

@jacobheun jacobheun jacobheun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make optional arguments last
3 participants
@dirkmc @jacobheun @vasco-santos