This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
feat!: Add remoteExtensions to connection-encrypter #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoPolo
commented
Sep 27, 2022
mpetrunic
suggested changes
Sep 28, 2022
12 tasks
MarcoPolo
changed the title
MarcoPolo
force-pushed
the
marco/remote-extensions
branch
from
7b68d40
to
bce2908
Compare
mpetrunic
approved these changes
Oct 4, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Oct 4, 2022
## [@libp2p/interface-connection-encrypter-v3.0.0](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/interface-connection-encrypter-v2.0.2...@libp2p/interface-connection-encrypter-v3.0.0) (2022-10-04) ### ⚠ BREAKING CHANGES * Add remoteExtensions to connection-encrypter (#293) ### Features * Add remoteExtensions to connection-encrypter ([#293](#293)) ([501c684](501c684))
|
🎉 This PR is included in version @libp2p/interface-connection-encrypter-v3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 4, 2022
## [@libp2p/interface-mocks-v5.0.0](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/interface-mocks-v4.0.3...@libp2p/interface-mocks-v5.0.0) (2022-10-04) ### ⚠ BREAKING CHANGES * Add remoteExtensions to connection-encrypter (#293) ### Features * Add remoteExtensions to connection-encrypter ([#293](#293)) ([501c684](501c684)) ### Dependencies * update sibling dependencies ([419f947](419f947))
|
🎉 This PR is included in version @libp2p/interface-mocks-v5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #291
earlyData in Noise has been deprecated in favor of a structured protobuf labeled Noise Extensions: libp2p/specs#453.
remoteExtensions and earlyData are both Noise specific. I'm not sure what the value is by having this interface defined here. Probably what we want is a minimum interface that callers expect, but the concrete implementation can return anything as long as it meets the minimum interface. This is a bigger change than I want to take, but probably the better solution that we should do when we have other encryption modules.
BREAKING CHANGE: remoteEarlyData is replaced by generic remoteExtensions