This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
Ensure queries stop after error or success #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobheun
suggested changes
Mar 28, 2019
ghost
assigned
jacobheun
reviewed
Mar 28, 2019
src/sim-server.js
Outdated
| @@ -0,0 +1,42 @@ | |||
| 'use strict' | |||
There was a problem hiding this comment.
Looks like this file was accidentally added?
dirkmc
force-pushed
the
fix/stop-queries
branch
from
3297293
to
65d8e0a
Compare
jacobheun
approved these changes
Mar 28, 2019
|
Released on |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently queries continue running
This PR changes the query function to return either
pathCompleteorqueryComplete, wherequeryCompleteindicates that the whole query should stop (not just this particular disjoint path)It also ensures that queries are stopped after a timeout or any other error.