Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

deps(dev): Upgrade aegir to 38.1.7 #257

Merged
merged 3 commits into from
Mar 21, 2023
Merged

Conversation

maschad
Copy link
Member

@maschad maschad commented Mar 20, 2023

Also reverting typescript to 4.9.5 because a3590af upgraded it, but aegir depends on eslint-plugin-etc ( as well as eslint-config-ipfs which also depends on eslint-plugin-etc) which is incompatible with TS5 atm cartant/eslint-plugin-etc#53.

@achingbrain
Copy link
Member

Why is there a direct dep on typescript here? Is it just an old mistake?

@maschad
Copy link
Member Author

maschad commented Mar 20, 2023

Not a direct dep, but currently master is failing because of an indirect dep on eslint-plugin-etc which is a peerDep of aegir ( I should have ran this test before merging #256) so essentially we can't use aegir with TS5 yet.

@achingbrain achingbrain changed the title deps: Upgrade aegir to 38.1.7 deps(dev): Upgrade aegir to 38.1.7 Mar 21, 2023
@achingbrain
Copy link
Member

Hmm, still not sure why there's a typescript dep here at all, there's nothing special or unique about the repo setup, I think it's just been hanging around for ages and was never removed.

@maschad
Copy link
Member Author

maschad commented Mar 21, 2023

I think I misunderstood the original comment 😅 thanks!

test/fixtures/utils.ts Outdated Show resolved Hide resolved
@achingbrain achingbrain merged commit e0bf45a into libp2p:master Mar 21, 2023
github-actions bot pushed a commit that referenced this pull request Mar 21, 2023
## [7.1.2](v7.1.1...v7.1.2) (2023-03-21)

### Trivial Changes

* replace err-code with CodeError ([#242](#242)) ([8d58a3b](8d58a3b)), closes [js-libp2p#1269](libp2p/js-libp2p#1269)
* Update .github/workflows/semantic-pull-request.yml [skip ci] ([54de88d](54de88d))
* Update .github/workflows/semantic-pull-request.yml [skip ci] ([df03e8d](df03e8d))
* Update .github/workflows/semantic-pull-request.yml [skip ci] ([9c3f235](9c3f235))

### Dependencies

* **dev:** bump typescript from 4.9.5 to 5.0.2 ([#256](#256)) ([a3590af](a3590af))
* **dev:** Upgrade aegir to 38.1.7 ([#257](#257)) ([e0bf45a](e0bf45a))
@github-actions
Copy link

🎉 This PR is included in version 7.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants