Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

chore: update multihashing-async dep #17

Merged
merged 2 commits into from
Jan 3, 2020

Conversation

alanshaw
Copy link
Member

@alanshaw alanshaw commented Jan 1, 2020

@vasco-santos @jacobheun do you have any plans to add automated dependency updating?

@vasco-santos @jacobheun do you have any plans to add automated dependency updating?
@vasco-santos
Copy link
Member

We did not discuss that topic yet, but I think that we should discuss this! Maybe an agenda item for the JS office hours?

@vasco-santos
Copy link
Member

vasco-santos commented Jan 2, 2020

@alanshaw I added a commit to fix the linter and just got the opportunity to update the remaining dependencies. is this ok for you? If so, I can go ahead and merge + release

Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alanshaw
Copy link
Member Author

alanshaw commented Jan 2, 2020

We did not discuss that topic yet, but I think that we should discuss this! Maybe an agenda item for the JS office hours?

That would be rad, for reference, I opened the following PRs recently in the libp2p world to update some out of range dependencies that were published months ago:

@vasco-santos
Copy link
Member

You are absolutely right! Let's define this next week :)

@vasco-santos vasco-santos merged commit 3793ea0 into master Jan 3, 2020
@vasco-santos vasco-santos deleted the chore/update-multihashing-async-dep branch January 3, 2020 09:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants