feat: Circuit Relay #224
feat: Circuit Relay #224
Conversation
| @@ -37,6 +38,7 @@ class LimitDialer { | |||
| log('dialMany:start') | |||
| // we use a token to track if we want to cancel following dials | |||
| const token = { cancel: false } | |||
| callback = once(callback) // only call callback once | |||
There was a problem hiding this comment.
@dignifiedquire since dialMany will possibly succeed for more than one address, the callback could resolve multiple times, this breaks in a couple of places (I'll have to see exactly where, but I believe it was either libp2p or swarm). I think having the callback called only once, for the first address that gets resolved, makes sense here?
There was a problem hiding this comment.
If we expect that, it should be set up such that the first one results in the callback being called, but in addition made sure that all others are canceled and no new ones are started to avoid waste
There was a problem hiding this comment.
Hmm, good idea. Would you mind if I leave this PR as is and open an issue to enhance dialMany in another issue? I don't want to hold this PR because of it.
dryajov
force-pushed
the
feat/circuit-v1.0.0
branch
4 times, most recently
from
5c9f0af
to
543572c
Compare
ghost
assigned 
…uit addr is provided
dryajov
force-pushed
the
feat/circuit-v1.0.0
branch
from
f205b29
to
5b3274b
Compare
|
This is currently blocked by - webpack/node-libs-browser#63 |
|
@dryajov mind updating this PR with all the released deps and make CI happy? |
|
Will do! |
dryajov
force-pushed
the
feat/circuit-v1.0.0
branch
from
b358901
to
c29c11f
Compare
dryajov
force-pushed
the
feat/circuit-v1.0.0
branch
from
d73f5bf
to
1654f85
Compare
|
@diasdavid I've fixed tests and updated the docs. |
No description provided.