Skip to content
This repository has been archived by the owner on Aug 23, 2019. It is now read-only.

improve connection close management #291

Merged
merged 16 commits into from
Dec 14, 2018
Merged

improve connection close management #291

merged 16 commits into from
Dec 14, 2018

Conversation

jacobheun
Copy link
Contributor

Handling multiple connections to a peer
Switch was previously only tracking 1 connection per peer, however it's possible to have more than 1 connection per peer. This adds the ability to track multiple connections per peer, but will attempt to use a single connection when possible.

Closing base connections #288
Switch was previously not properly closing the base connection. This could result in streams staying open on the receiver side if they allow half open connections. Now when a connection is closing, we abort the base pull stream connection to notify the receiver that we're done.

  • Ensure there is a transport before filtering dialables.
  • Stat starting and stopping are better tied into the switch start and stop

@ghost ghost assigned jacobheun Dec 13, 2018
@ghost ghost added the in progress label Dec 13, 2018
fix: improve logic around disconnecting

fix: remove duplicate event handling logic
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jacobheun jacobheun merged commit aa86307 into master Dec 14, 2018
@ghost ghost removed the in progress label Dec 14, 2018
@jacobheun jacobheun deleted the fix/many-conns branch December 14, 2018 15:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants