Streams are never closed

[achingbrain]

The following simple echo stream code does not work:

import all from 'it-all'

const stream = await connection.newStream(echo)
const input = new Array(5).fill(0).map(() => new Uint8Array(10))

const output = await pipe(
  input,
  stream,
  all
)
console.info('all done') // <- never reached

The reason is the internal _sink method merges the source stream with a "close write iterable" that waits for the closeWritePromise deferred promise to resolve. This is done in the finally block of the sink method.

This block is never reached because the this._sink call doesn't return - it's waiting for the closeWritePromise deferred promise to resolve which creates a deadlock.

[marcus-pousette]

Can a keepAliveTimeout help ? Perhaps not ideal, but there is no information that no more elements are going to propagate through.

[github-actions]

🎉 This issue has been resolved in version 2.0.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀