fix(@libp2p/webtransport): maximum call stack size exceeded on abort #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug in webtransport where the `.abort` method on the stream class was calling `stream.abort` and leading to a call stack overflow.
achingbrain
commented
Aug 9, 2023
| writer.abort() | ||
| writerClosed = true | ||
| } | ||
| stream.abort(err) |
There was a problem hiding this comment.
This is where the call stack overflow was happening.
achingbrain
changed the title
|
@achingbrain I am not familiar with this commit convention, where is it derived from? |
|
Do you mean the |
|
It's hard to fit the scope into the git commit and still be under 50 characters, but with modern technology, I prefer scoped commits rather than short git commit messages. |
SgtPooki
reviewed
Aug 11, 2023
Comment on lines
+7
to
+12
| export function isSubset (set: Uint8Array[], maybeSubset: Uint8Array[]): boolean { | ||
| const intersection = maybeSubset.filter(byteArray => { | ||
| return Boolean(set.find((otherByteArray: Uint8Array) => uint8ArrayEquals(byteArray, otherByteArray))) | ||
| }) | ||
| return (intersection.length === maybeSubset.length) | ||
| } |
There was a problem hiding this comment.
do we need this to be Uint8array or can it be generic?
This was referenced Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug in webtransport where the
.abortmethod on the stream class was callingstream.abortand leading to a call stack overflow.Also splits the code into multiple files to make it a bit easier to see what is doing what.