Update webrtc and improve test consistency #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
jacobheun
changed the title
|
@diasdavid I added a fix for test flakiness to this as well so we shouldn't see intermittent multicastDNS test failures anymore. |
daviddias
reviewed
Jun 29, 2018
| @@ -73,7 +73,7 @@ | |||
| "pull-serializer": "~0.3.2", | |||
| "pull-stream": "^3.6.8", | |||
| "sinon": "^5.0.7", | |||
| "wrtc": "0.1.1" | |||
| "wrtc": "~0.1.6" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webrtc update
This should resolve #204 and #194.
The latest node-webrtc, 0.1.6, fixed an issue that was causing wrtc to fail.
I've verified this locally, and it looked good on the initial build of jenkins aside from an out of space issue. Jenkins is not having a good day/evening. I will re-run the build tomorrow so we get a clean green.
Test stability
There was an issue where running libp2p-mdns on jenkins could end up giving us wrong CIDs because the network is shared between tests. This adds a random serviceTag instead of using the default, which isolates the multicastDNS queries to the specific tests. This should prevent flakiness in those tests.