refactor: move setMaxListeners to @libp2p/interface #2154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
requested changes
Oct 12, 2023
achingbrain
force-pushed
the
refactor/move-set-max-listeners
branch
from
c3b64ce
to
696607f
Compare
- Discussed in #2138 - Move `setMaxListeners` handling into a single wrapped function exported from `@libp2p/interface/events` - Instead of setting `"browser": {"events": false}` as was discussed in #2138, an actual file is given. Without doing this, an annoying warning is produced in this package and every consumer package in the monorepo!
achingbrain
force-pushed
the
refactor/move-set-max-listeners
branch
from
696607f
to
8019d6f
Compare
achingbrain
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
setMaxListenershandling into a single wrapped function exported from@libp2p/interface/eventsNotes
"browser": {"events": false}as was discussed in Improve Cross-environment portability of libp2p core #2138, an actual file is given. Without doing this, an annoying warning is produced in this package and every consumer package in the monorepo!Change checklist