refactor!: remove per-peer parallel dialling #2163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wemeetagain
reviewed
Oct 26, 2023
doc/migrations/v0.46-v1.0.0.md
Outdated
|
|
||
| ## Connection Manager | ||
|
|
||
| We now only dial one peer at a time as this is a more efficient use of resources. This means that the `maxParallelDialsPerPeer` option has been removed. |
There was a problem hiding this comment.
I don't think this is right. We're removing parallel dials per peer, but not across peers.
There was a problem hiding this comment.
I've updated the note, hopefully it's clearer. It has a bit of the "why" as well as the "what" now.
achingbrain
force-pushed
the
release-v1.0
branch
6 times, most recently
from
c347bf2
to
c8b71d8
Compare
Since we are now dialling one peer at a time as a means of smarter dialling, we no longer need the option to control the concurrency of parallel dials across a single peers' multiaddrs. Closes libp2p#2090
achingbrain
force-pushed
the
fix/remove-parallel-dialling
branch
from
81c26e4
to
4101b23
Compare
achingbrain
changed the title
achingbrain
reviewed
Oct 31, 2023
achingbrain
approved these changes
Oct 31, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since we are now dialling one peer at a time as a means of smarter dialling, we no longer need the option to control the concurrency of parallel dials across the multiaddrs of a single peer.
Closes #2090
Notes & open questions
Change checklist