fix: do not overwrite addresses on identify push when none are sent #2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
force-pushed
the
fix/debug-interop
branch
from
2089667
to
dac2859
Compare
achingbrain
changed the title
achingbrain
force-pushed
the
fix/debug-interop
branch
from
dac2859
to
81753ba
Compare
During identify-push in response to a protocol update go-libp2p does not send a signed peer record or the current list of listen addresses. Protobuf does not let us differentiate between an empty list and no list items at all because the field is just repeated - an absence of repeated fields doesn't mean the list was omitted. When the listen address list is empty, preserve any existing addresses.
achingbrain
force-pushed
the
fix/debug-interop
branch
from
81753ba
to
268c42b
Compare
This was referenced Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During identify-push in response to a protocol update go-libp2p does not send a signed peer record or the current list of listen addresses.
This manifests in intermittent interop test failures where we have no valid addresses for a dial, when we dial a peer ID after adding multiaddrs for it to the peer store.
Protobuf does not let us differentiate between an empty list and no list items at all because the field is just
repeated- an absence of repeated fields doesn't mean the list was omitted.