Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: log peer data in identify correctly #2197

Merged
merged 1 commit into from
Nov 6, 2023
Merged

fix: log peer data in identify correctly #2197

merged 1 commit into from
Nov 6, 2023

Conversation

achingbrain
Copy link
Member

When logging peer data, pass the peer id and the update to the logger instead of just the update values, otherwise the values get logged as [object Object].

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain achingbrain requested a review from a team as a code owner November 4, 2023 07:47
@achingbrain
fix: log peer data in identify correctly
3e50809 
When logging peer data, pass the peer id and the update to the
logger instead of just the update values, otherwise the values get
logged as `[object Object]`.
@achingbrain achingbrain merged commit fdcb801 into master Nov 6, 2023
22 checks passed
@achingbrain achingbrain deleted the fix/identify-logging branch November 6, 2023 07:43
This was referenced Jan 18, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@achingbrain