feat: add confidence in observed addresses #881
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Require at least four peers to report the same observed address before we start returning it as part of `node.multiaddrs`. In order to not let the list of observed addresses grow forever we enforce a 10 minute timeout, that is for any observed address, at least four different peers have to report it to us within ten minutes otherwise we discard the address. The number of peers and timeout are both configurable.
vasco-santos
suggested changes
Feb 1, 2021
|
We will merge #882 and think more about how to add confidence to the observed addresses |
|
Closing for now, can be picked up as part of #703 when that gets prioritized again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require at least four peers to report the same observed address before
we start returning it as part of
node.multiaddrs.In order to not let the list of observed addresses grow forever we
enforce a 10 minute timeout, that is for any observed address, at least
four different peers have to report it to us within ten minutes otherwise
we discard the address.
The number of peers and timeout are both configurable.